Prevent closing and re-opening the serial port several times, fixes issue 16 (and probably 18)#19
Open
rreilink wants to merge 1 commit intoole00:masterfrom
Open
Prevent closing and re-opening the serial port several times, fixes issue 16 (and probably 18)#19rreilink wants to merge 1 commit intoole00:masterfrom
rreilink wants to merge 1 commit intoole00:masterfrom
Conversation
…ssue 16 (and probably 18)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of opening and closing the serial port for every step, do it only once. This solves the issues related to the arduino resetting in between, and speeds up the programming since each resets costs a few seconds (may be depending on the Arduino type)
With this PR, the changes related to the 'noinit' of the Arduino gal variable could be reverted; I can make a commit for this if desired.