Skip to content

Conversation

@Dashlorde
Copy link
Collaborator

No description provided.

@empeje
Copy link
Contributor

empeje commented Mar 9, 2018

Congratulations

@empeje
Copy link
Contributor

empeje commented Mar 9, 2018

Related to #1

Copy link
Contributor

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work but you need to reduce hardcoded value.

See #3

@empeje
Copy link
Contributor

empeje commented Mar 13, 2018

Can you create a screenshot of the working bell docker on the docker.ole.org?
I have limited time to test your setup, but your demonstration will help the review process.

@Dashlorde
Copy link
Collaborator Author

I run the bell on docker.ole.org:8080
screen shot 2018-03-13 at 3 56 34

@empeje
Copy link
Contributor

empeje commented Mar 14, 2018

Awesome @Dashlorde

Copy link
Member

@dogi dogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dashlorde good job - added some change wishes


RUN mkdir -p /app/server/src && \
apk add --update openssl && npm install express && \
wget -O BeLL-Apps-${version}.tar.gz \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed ...

wget -O BeLL-Apps-${version}.tar.gz \
https://github.com/open-learning-exchange/BeLL-Apps/archive/${version}.tar.gz && \
tar xvf BeLL-Apps-${version}.tar.gz && \
mv BeLL-Apps-${version}/* /app/server/src/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... until here


PortJack.get(/^(.+)$/, function(req, res) {

res.setHeader('Location', 'http://' + HOST + ':2200/apps/_design/bell/MyApp/index.html')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please lets not use 2200 port

5984 is couchdb standard

@@ -0,0 +1,24 @@
FROM hypriot/rpi-node:6.10.0-alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name of this file should be Dockerfile not dockerfile

fi

# Default port for CouchDB accessed from host machine is 2200
PORT=${PORT:-2200}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use for default port 5984

couchdb:
expose:
- 5984
image: treehouses/rpi-couchdb:2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use old couchdb 1.6.1

- 5984
image: treehouses/rpi-couchdb:2.0.0
ports:
- "2200:5984"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no 2200 just strait 5984

image: treehouses/rpi-couchdb:2.0.0
ports:
- "2200:5984"
- "2201:5986"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with couchdb 1.6.1 this line is not needed

@@ -0,0 +1,21 @@
services:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as in arm/docker-compose-ready.yml

@@ -0,0 +1,23 @@
FROM hypriot/rpi-node:6.10.0-alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name of this file should be Dockerfile not dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants