Skip to content

Comments

fix: follow docs 2 get sign in flow w/ outseta #12#13

Open
olavea wants to merge 6 commits intomainfrom
Outseta-sign-in-flow
Open

fix: follow docs 2 get sign in flow w/ outseta #12#13
olavea wants to merge 6 commits intomainfrom
Outseta-sign-in-flow

Conversation

@olavea
Copy link
Owner

@olavea olavea commented Dec 1, 2021

This is not working yet, I need input

@olavea olavea requested a review from raae December 1, 2021 09:40
@olavea olavea self-assigned this Dec 1, 2021
@olavea olavea removed the request for review from raae December 1, 2021 09:41
Copy link
Collaborator

@raae raae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Did not try to run it.

gatsby-ssr.js Outdated

return (
<script
key="fathom-script"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 1, 2021

Gatsby Cloud Build Report

TimeShip-1

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 97
Accessibility 💚 94
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

key="fathom-script"
src="https://cdn.outseta.com/outseta.min.js"
></script>
const OutsetaScriptComponent = () => {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Looks like gatsby is not reading my const o_options variable the way I want. 👇 😺
    Uncaught Error: [domain] is a required option to initialize the Outseta script.

  2. But gatsby IS reading my script tag
    look 👇 😸 👍
    outseta.min.js:2

Here is the screenshot:
Geoff-Uncaught Error-  domain  is a required option to initialize the Outseta script -3 3

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still getting this error in my Console

Uncaught Error: [domain] is a required option to initialize the Outseta script.

outseta.min.js:2

in this commit e0ee2b9

olavea added a commit that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants