-
Notifications
You must be signed in to change notification settings - Fork 4
Add xBETH and refactor xBTC #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doutv
wants to merge
36
commits into
xbtc-evm
Choose a base branch
from
xbeth-evm
base: xbtc-evm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. solidity version 0.6.12 -> 0.8.24 2. based on FiatTokenV2_1 -> xbtc 3. onlyOwner -> onlyRole(DEFAULT_ADMIN_ROLE)
…ion instead of a constant
…to reflect changes in initialization parameters and contract references.
1. solidity version 0.8.6 -> 0.8.24 2. OZ 4.x -> 5.x. Ownable now requires an initialOwner parameter in its constructor Address library functionCall and functionStaticCall signatures changed - the error message is now optional
…d compilation efficiency.
…ntracts - Introduced ExchangeRateUpdaterTest with tests for initialization, exchange rate updates, and ownership management. - Added ExchangeRateUpdaterE2ETest for end-to-end testing of the exchange rate update flow. - Created RateLimitTest covering caller management, allowance replenishment, and edge cases. - Implemented RateLimitHarness for testing internal functions of the RateLimit contract.
…umentation and implementation. default decimals = 18
…integration tests for StakedTokenV1 and ExchangeRateUpdater, including scenarios for daily rate updates, multiple callers, and emergency updates.
…l implementations
…al implementations and enhance code consistency
…sion 5.4.0 for consistency and stability
…h author and repository details, and remove package-lock.json to streamline dependency management.
…e token details, and enhance documentation on architecture, features, and project structure.
…nments for admin and denyLister
…ole management tests
…ript, ensuring it is both ProxyAdmin owner and has DEFAULT_ADMIN_ROLE in Token contract.
…just like in production
…ntract to scritps
…es, it's easier to compare code changes
…update verification methods for initialization values across tests.
…ipts to use abi.encodeCall for improved type safety and clarity.
…inbase" to "org.okx" for consistency with new naming conventions.
…ation - Introduced .env.forge.example for environment variable setup. - Created DeployXETH script to deploy xETH token with proxy, including role assignments and initialization logic.
f56e87d to
e8a0b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt StakedTokenV1 and ExchangeRateUpdater from cbETH
Differences with cbETH https://github.com/coinbase/wrapped-tokens-os/tree/5697a90f4c47e8d801cedce81444a8464019fe08:
StakedTokenV1.sol
ExchangeRateUpdater.sol, ExchangeRateUtil.sol, RateLimit.sol
Adapt xToken from xBTC, make it more general for other xAssets