Fix reth-bench-tool node fails to start #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliff0412
reviewed
Nov 14, 2025
| /// XLayer: custom chain names are not of `alloy` chain enum, and this name is passed | ||
| /// into reth node as arg. If we passed in a numerical value to `--chain`, the reth node | ||
| /// fails to start. | ||
| fn custom_chainname(&self, chain_str: String, is_id: bool) -> String { |
There was a problem hiding this comment.
i think it's better to add xlayer chain name in alloy
Author
There was a problem hiding this comment.
Sounds good if I were only testing mainnet. But for testnet, I do not believe we commit such a change to alloy?
Author
There was a problem hiding this comment.
Maybe passing an arg to override the chainname (if no exist) will allow any custom name to be passed?
There was a problem hiding this comment.
i think this can be committed temparary, but pls add a mark TODO to commit to alloy later on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38.