Fix compiler error upgrading lightstreamer version#50
Fix compiler error upgrading lightstreamer version#50AndreJackBia wants to merge 3 commits intook24601:masterfrom
Conversation
Will works now? |
|
Builds successfully on my machine
Il sab 19 mar 2022, 14:11 username77 ***@***.***> ha scritto:
… Fix issue #49 <#49>: compile
error Upgraded lightstreamer version to 4.3.7 Updated listeners to override
new abstract methods
Will works now?
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFMYYYXCNNZVRBROXVJLSYDVAXG7XANCNFSM5REAFGCA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| val image = Image(imageData.getInt("Width"), imageData.getInt("Height"), imageData.getString("Uri")) | ||
| val image = Image(0,0, ""); | ||
| try { | ||
| val image = Image(imageData.getInt("Width"), imageData.getInt("Height"), imageData.getString("Uri")) |
There was a problem hiding this comment.
you are overriding image, remove val on this line and change val image to var on line 120
There was a problem hiding this comment.
Still doesn't fix the issue around the non-updating watchlist...
There was a problem hiding this comment.
You need to add a required boolean parameter to CreateSessionRequest class constructor, otherwise the request silently crashes. However, at least for me, the updates still don't occur even after
There was a problem hiding this comment.
class CreateSessionRequest(targetServer: String, polling: Boolean, cause: String?, options: InternalConnectionOptions, details: InternalConnectionDetails, delay: Long, password: String?, oldSession: String?, serverBusy: Boolean) : SessionRequest(polling, delay) {
|
Does it work? I added something to the watchlist but I get no updates. I also downloaded the old ls-javase-client:3.1.1 but I keep not getting any updates from my watchlist |
Fix issue #49: compile error
Upgraded lightstreamer version to 4.3.7
Updated listeners to override new abstract methods