Implement get user by email and name #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slhmy
requested changes
Jul 22, 2025
proto/user.proto
Outdated
|
|
||
| message GetUserByNameRequest { string name = 1; } | ||
|
|
||
| message GetUserByNameResponse { |
Member
There was a problem hiding this comment.
What's the difference between ListUsers?
Member
Author
There was a problem hiding this comment.
ListUsers is for user list, GetUserByName/Email is for user search.
Member
There was a problem hiding this comment.
No, search should be an optional choice inside ListUsers.
If we consider some situation that normal users need user search feature, it can be other service like ListUserInfo etc. It'll only provide limited information.
slhmy
requested changes
Jul 24, 2025
internal/repository/user.go
Outdated
Comment on lines
18
to
19
| List(ctx context.Context, offset, limit int, name, email *string, role *model.UserRole) ([]*model.UserModel, error) | ||
| Count(ctx context.Context, name, email *string, role *model.UserRole) (int64, error) |
Member
There was a problem hiding this comment.
Squash these input parameters into a struct to improve readability, there are too many of them now.
For me using userpb.ListUsersRequest is also okay.
slhmy
approved these changes
Jul 25, 2025
slhmy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Close #22