Support Url Injection for mock oauth service test #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeepingRunning
force-pushed
the
Url-injection
branch
from
ffd9127 to
ceb9654
Compare
slhmy
reviewed
Jul 11, 2025
Comment on lines
+26
to
+28
| optional string auth_url = 3; | ||
| optional string token_url = 4; | ||
| optional string api_base_url = 5; |
Member
There was a problem hiding this comment.
Not making sense for me.
If it's a completly copied GitHub OAuth API, these url don't need to be changed (since changing GitHub BaseURL will be enough).
Member
|
Closed for unwanted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows the user-service to work with both real GitHub API and mock GitHub services by dynamically injecting API endpoints during OAuth flows, improving development and testing capabilities.
Warning
Related Issue
Closes #19