Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Fix template-related issue in Constant.h

This PR addresses the template-related issue in PR #891 where the compiler expects a declaration of NewDefaultValuable() before it's used in Constant.h.

Changes

  • Modified CompileIntoLambda method in Constant.h to use Chld::GlobalObject instead of NewDefaultValuable()
  • This approach avoids adding a new method and potential function redefinition errors

Issue

The original error was:

there are no arguments to 'NewDefaultValuable' that depend on a template parameter, so a declaration of 'NewDefaultValuable' must be available [-fpermissive]

This was causing build failures on both Ubuntu and Windows CI environments.

Link to Devin run: https://app.devin.ai/sessions/008b72343e894ad39f52e03252e8311c
Requested by: ohhmm

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@ohhmm ohhmm force-pushed the devin/1741722025-pr-comment-fix-v2 branch from 09fed90 to 2200f04 Compare March 12, 2025 17:29
Co-Authored-By: Serg Kryvonos <sergeikrivonos@gmail.com>
@ohhmm ohhmm force-pushed the devin/1741722025-pr-comment-fix-v2 branch from 2200f04 to 806d647 Compare March 13, 2025 08:06
@ohhmm ohhmm changed the base branch from vs-clang-fix to main March 13, 2025 17:59
@ohhmm ohhmm merged commit a6c7721 into main Mar 13, 2025
10 checks passed
@ohhmm ohhmm deleted the devin/1741722025-pr-comment-fix-v2 branch March 13, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant