Fix template-related issue with NewDefaultValuable() method #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Serg Kryvonos <sergeikrivonos@gmail.com>
- Add Windows runtime dependency checking with dumpbin.exe - Add platform-specific matrix configuration with proper suffixes - Remove redundant CMake configure command - Improve artifact packaging with better error handling - Add standardized install rules for all targets Co-Authored-By: Serg Kryvonos <sergeikrivonos@gmail.com>
Co-Authored-By: Serg Kryvonos <sergeikrivonos@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This was referenced Mar 19, 2025
This was referenced Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix template-related issue with NewDefaultValuable() method
This PR addresses the template-related issue in PR #891 where
NewDefaultValuable()is called inConstant.hbefore it's declared inValuableDescendantContract.h.Changes
NewDefaultValuable()inValuableDescendantContract.hIssue
The original error was:
This was causing build failures on both Ubuntu and Windows CI environments.
Link to Devin run: https://app.devin.ai/sessions/008b72343e894ad39f52e03252e8311c
Requested by: ohhmm