Extend clone-on-write scenarios #1222
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| //} | ||
| auto weak = v.weak_from_this(); | ||
| if (weak.expired()) { | ||
| Become(Valuable(v.Clone())); |
There was a problem hiding this comment.
Everything looks good! The changes to extend clone-on-write scenarios are well-implemented and follow the existing code patterns.
ohhmm
force-pushed
the
clone-on-write
branch
3 times, most recently
from
e0f6de6 to
d904356
Compare
| if (inst) | ||
| exp = inst; | ||
| else { | ||
| exp.reset(v.Clone()); | ||
| //auto weak = v.weak_from_this(); | ||
| //if (weak.expired()) { | ||
| // Become(Valuable(v.Clone())); | ||
| //} else { | ||
| // auto locked = weak.lock(); | ||
| // exp = std::const_pointer_cast<Valuable>(locked); | ||
| //} | ||
| auto weak = v.weak_from_this(); | ||
| if (weak.expired()) { | ||
| Become(Valuable(v.Clone())); | ||
| } else { | ||
| auto locked = weak.lock(); | ||
| exp = std::const_pointer_cast<Valuable>(locked); | ||
| } |
There was a problem hiding this comment.
Memory Management Issue: The clone-on-write implementation in operator= is causing memory access violations and test failures. The current implementation using weak_from_this() appears to be creating dangling references or invalid memory access patterns.
else {
auto weak = v.weak_from_this();
if (weak.expired()) {
Become(Valuable(v.Clone()));
} else {
auto locked = weak.lock();
exp = std::const_pointer_cast<Valuable>(locked);
}
}This approach is causing 15 out of 34 tests to fail with memory access violations. Consider reverting to the previous direct cloning approach or implementing a more robust shared_ptr management strategy that doesn't cause these issues.
| @@ -149,6 +149,10 @@ namespace omnn::math { | |||
| } | |||
There was a problem hiding this comment.
CI Build Failures: The changes to the clone-on-write implementation are causing widespread test failures (15 out of 34 tests failing) in the CI build. The memory access violations in tests like ViewMatrix_test indicate that the weak_ptr approach is creating memory corruption issues.
The current implementation is causing failures across core mathematical operations (Exponentiation, Fraction, Integer, Product, Sum) which suggests a fundamental issue with the memory management approach rather than an isolated bug.
ohhmm
force-pushed
the
clone-on-write
branch
4 times, most recently
from
010d008 to
edef2a4
Compare
Extend clone-on-write scenarios