Add CheckResult enum with warning state support and helper methods#69
Draft
mattiasgeniar wants to merge 1 commit intomainfrom
Draft
Add CheckResult enum with warning state support and helper methods#69mattiasgeniar wants to merge 1 commit intomainfrom
mattiasgeniar wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Oh Dear's uptime checks now have a warning state — when the primary checker reports down but the secondary location confirms the site is still reachable. The SDK needs a way to work with check result states beyond raw string comparisons.
What changed
CheckResultbacked string enum with all five result states and helper methods (isUp(),isDown(),isPending(),isWarning())checkResult()method onCheck,Monitor, andCheckSummaryDTOs returns the typed enumlatestRunResult,summarizedCheckResult,result) are unchanged — no breaking changes