feat: persist 및 초기 상태 개선 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves initial state management and persistence by enhancing storage handling and code initialization. The changes implement proper hydration error handling with automatic storage cleanup and restore initial code from persisted state.
Key Changes:
- Added
onRehydrateStorageoption to handle persistence failures and reset execution state on app restart - Implemented
getInitialCodefunction to initialize editor with persisted code from localStorage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/executeJS/src/pages/editor/editor-page.tsx | Added getInitialCode function to restore code from localStorage with fallback to default message |
| apps/executeJS/src/features/execute-code/model.ts | Added onRehydrateStorage callback to handle hydration errors and reset execution state |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enjoywater
force-pushed
the
feat/initial-state
branch
from
33a1131 to
5acb747
Compare
ohah
pushed a commit
that referenced
this pull request
Dec 12, 2025
* feat: persist 에러 처리 추가 * feat: 실행 이력에 따른 초기 상태 * fix: format * fix: 파일명 오류 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 요약
📝 작업 내용
🔍 스크린샷
2025-10-28.1.mov
💡 참고 사항