Skip to content

탭 버튼 위 우클릭 시 context menu 기능 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bori-github merged 10 commits into from
Nov 2, 2025
Merged

탭 버튼 위 우클릭 시 context menu 기능 #14

Bori-github merged 10 commits into from
Nov 2, 2025

Conversation

@Bori-github
Copy link
Collaborator

@Bori-github Bori-github commented Nov 2, 2025

📌 요약

  • 탭 버튼 위 우클릭 시 context menu 기능

📝 작업 내용

  • react-hook-form 패키지 추가
  • useClickOutside 커스텀 훅 생성
  • 탭 버튼 위 우클릭 시 context menu 기능
    • 탭 닫기 기능
    • 탭 제목 변경 기능

🔍 스크린샷

2025-11-02.4.52.21.mov

💡 참고 사항

  • 없음

@Bori-github Bori-github self-assigned this Nov 2, 2025
@Bori-github Bori-github added the enhancement New feature or request label Nov 2, 2025
@ohah
Copy link
Owner

ohah commented Nov 2, 2025

@copilot 코드 리뷰 봐주세요

Copilot AI mentioned this pull request Nov 2, 2025
Closed
Copy link

Copilot AI commented Nov 2, 2025

@ohah I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.

@ohah ohah requested a review from Copilot November 2, 2025 09:08
Copilot AI reviewed Nov 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ohah ohah requested a review from Copilot November 2, 2025 09:26
ohah
ohah approved these changes Nov 2, 2025
View reviewed changes
Copy link
Owner

@ohah ohah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달도 괜찮구 나중에 그냥 탭에서 바로 이름 편집 되게 해도 좋을것 같아여

Copilot AI reviewed Nov 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Bori-github
Copy link
Collaborator Author

Bori-github commented Nov 2, 2025

모달도 괜찮구 나중에 그냥 탭에서 바로 이름 편집 되게 해도 좋을것 같아여

@ohah
탭에서 바로 이름 편집하는거 잠깐 고민했는데, 저장이랑 닫기 영역 때문에 input 영역 좁아지는거 생각하다가 그냥 모달로 해버렸어요~
나중에 다시 고민해봄! 땡큐!

@Bori-github Bori-github merged commit 89db7a9 into main Nov 2, 2025
3 checks passed
ohah pushed a commit that referenced this pull request Dec 12, 2025
@Bori-github
탭 버튼 위 우클릭 시 context menu 기능 (#14)
b38e9ae 
* feat: useClickOutside 커스텀 훅 생성

* feat: 탭 버튼에서 마우스 우클릭 시 context menu 노출

* chore: react-hook-form 패키지 추가

* feat: context menu > change tab title 클릭 시 탭 제목 변경 모달 노출되도록 적용

* feat: 탭 제목 변경 기능

* style: 탭 제목 모달 내 저장 버튼 커서 스타일 수정

* chore: 파일명 오타 수정

* chore: 탭 제목 유효성 검사 추가

* fix: 탭 제목 변경 후 다시 모달 진입한 경우, 탭 제목이 이전 값을 가지고 있는 문제 수정

* chore: useClickOutside 훅에서 onClickOutside 함수에 이벤트 인자를 추가하고, 이벤트 리스너를 동적으로 처리하도록 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ohah ohah ohah approved these changes

@Enjoywater Enjoywater Awaiting requested review from Enjoywater Enjoywater is a code owner

Assignees

@Bori-github Bori-github

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bori-github @ohah