Skip to content

Conversation

@ohah
Copy link
Owner

@ohah ohah commented Oct 19, 2025

Fix/lint import

@ohah ohah self-assigned this Oct 19, 2025
@ohah ohah added the bug Something isn't working label Oct 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses linting and import issues by removing unused exports and making logging initialization conditional. The changes streamline the codebase by removing unnecessary exports and simplifying the development workflow.

Key changes:

  • Removed unused model export from network-header widget
  • Made logging initialization conditional based on LOG environment variable
  • Simplified development command by removing log backup step (moved to separate script)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tauri-ui/src/widgets/network-header/index.ts Removed unused model export
tauri-ui/src-tauri/tauri.conf.json Simplified beforeDevCommand by removing log backup
tauri-ui/src-tauri/src/main.rs Made logging initialization conditional on LOG environment variable
tauri-ui/package.json Added new tauri:dev:log script for development with logging
.github/workflows/javascript-lint.yml Reordered pnpm installation to occur before Node.js setup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 23 to 33
- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 10

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "22"
cache: "pnpm"

Copy link

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm installation should remain after Node.js setup when using the 'cache: pnpm' option. The setup-node action expects pnpm to be configured after it runs to properly utilize the cache feature. This reordering may cause cache resolution issues.

Suggested change
- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 10
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "22"
cache: "pnpm"
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "22"
cache: "pnpm"
- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 10

Copilot uses AI. Check for mistakes.
ohah and others added 2 commits October 20, 2025 00:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ohah ohah merged commit 88200cf into master Oct 19, 2025
2 checks passed
@ohah ohah deleted the fix/lint-import branch October 19, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants