-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/lint import #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/lint import #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses linting and import issues by removing unused exports and making logging initialization conditional. The changes streamline the codebase by removing unnecessary exports and simplifying the development workflow.
Key changes:
- Removed unused model export from network-header widget
- Made logging initialization conditional based on LOG environment variable
- Simplified development command by removing log backup step (moved to separate script)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tauri-ui/src/widgets/network-header/index.ts | Removed unused model export |
| tauri-ui/src-tauri/tauri.conf.json | Simplified beforeDevCommand by removing log backup |
| tauri-ui/src-tauri/src/main.rs | Made logging initialization conditional on LOG environment variable |
| tauri-ui/package.json | Added new tauri:dev:log script for development with logging |
| .github/workflows/javascript-lint.yml | Reordered pnpm installation to occur before Node.js setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 10 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "22" | ||
| cache: "pnpm" | ||
|
|
Copilot
AI
Oct 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pnpm installation should remain after Node.js setup when using the 'cache: pnpm' option. The setup-node action expects pnpm to be configured after it runs to properly utilize the cache feature. This reordering may cause cache resolution issues.
| - name: Install pnpm | |
| uses: pnpm/action-setup@v4 | |
| with: | |
| version: 10 | |
| - name: Setup Node.js | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: "22" | |
| cache: "pnpm" | |
| - name: Setup Node.js | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: "22" | |
| cache: "pnpm" | |
| - name: Install pnpm | |
| uses: pnpm/action-setup@v4 | |
| with: | |
| version: 10 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fix/lint import