Skip to content

Update gh.fish#2

Open
jffiorillo wants to merge 2 commits intooguzbilgic:masterfrom
jffiorillo:python_issue
Open

Update gh.fish#2
jffiorillo wants to merge 2 commits intooguzbilgic:masterfrom
jffiorillo:python_issue

Conversation

@jffiorillo
Copy link

Fix print issue with python 3.6.5 Fix #1

Fix print issue with python 3.6.5
@oguzbilgic
Copy link
Owner

Applying your fix I get the following error 😞

  File "<string>", line 1
    import sys; url = sys.stdin.readlines()[0].strip(); print(url.split(':')[1][:-4)]
                                                                                   ^
SyntaxError: invalid syntax

I'm guessing this is python version issue, mine is:

Python 2.7.16 (default, Aug 24 2019, 18:37:03)

I wonder if we can rewrite this function without python and drop the dependency.

Removed python dependency.

Using argparse to parse argument in gh function.
@jffiorillo
Copy link
Author

Good idea @oguzbilgic ! I removed the python dependency and updated the other function to receive the parameter using argparse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

org_repo function doesn't work

2 participants