Replace k8scsi quay.io docker images by registry.k8s.io/sig-storage (and upgrade csi-resizer docker image from 0.2.0 to 0.5.0)

[yanis-corselle]

Following #186, as main repo is no more working because images have been moved, i propose to update their paths.

[gemini-code-assist]

Summary of Changes

Hello @yanis-corselle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where Kubernetes CSI driver images were no longer accessible from their previous location. It updates the image references within the deployment configuration to point to the new official registry.k8s.io/sig-storage registry, ensuring the continued functionality of the CSI components.

Highlights

• Image Registry Update: Replaced quay.io/k8scsi image paths with registry.k8s.io/sig-storage for various CSI components.
• CSI Node Driver Registrar: The csi-node-driver-registrar image path was updated to registry.k8s.io/sig-storage/csi-node-driver-registrar:v1.2.0.
• CSI Provisioner: The csi-provisioner image path was updated to registry.k8s.io/sig-storage/csi-provisioner:v1.6.0.
• CSI Resizer Update: The csi-resizer image path was updated to registry.k8s.io/sig-storage/csi-resizer:v0.5.0, also bumping its version from v0.2.0 to v0.5.0.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the container image paths for CSI sidecar containers from quay.io/k8scsi to the new official registry.k8s.io/sig-storage repository. This is a necessary change as the old repository is deprecated. My review found that these changes, while correct for the base manifests, will break the stable-gke kustomize overlay because it references the old image names. I've left comments on each updated image in deploy/base/daemonset.yaml detailing the required changes in deploy/overlays/stable-gke/kustomization.yaml to fix the overlay. The version of csi-resizer was also bumped, which requires special attention for the GKE overlay versioning.

[ofek]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly updates the container image registry from the deprecated quay.io/k8scsi to the current registry.k8s.io/sig-storage. This is a necessary and well-executed change. I've identified a minor version inconsistency for the csi-resizer image between the base configuration and the GKE overlay, and have provided a suggestion to align them.

[yanis-corselle]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the container image registries for CSI sidecar components from quay.io/k8scsi to registry.k8s.io/sig-storage, which is a necessary change as the old registry is deprecated. The changes are mostly correct, but I've identified an undocumented version upgrade for the csi-resizer component from v0.2.0 to v0.5.0. This is a significant change that could have side effects, and I've left comments highlighting that this change should be explicitly documented to clarify the scope and impact of the PR.

[yanis-corselle]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the container image registry for CSI sidecar components from quay.io/k8scsi to the official registry.k8s.io/sig-storage. It also upgrades the csi-resizer image from v0.2.0 to v0.5.0. The registry update is a good maintenance task. However, the version upgrade of csi-resizer introduces a dependency on Kubernetes v1.16+, which could be a breaking change for users on older clusters. I've added a comment with more details on this potential issue and suggested alternatives.

[gemini-code-assist]

Upgrading csi-resizer to v0.5.0 introduces a minimum Kubernetes version requirement of 1.16+. This could be a breaking change if this project supports Kubernetes versions older than 1.16. The previous version v0.2.0 was compatible with Kubernetes 1.13+.

While the upgrade to a version supporting leader election is a good fix for the previous configuration (which used leader election flags with an incompatible version v0.2.0), v0.5.0 might be too recent.

If backward compatibility with older Kubernetes versions is required, you might consider using v0.3.0 which requires Kubernetes 1.14+ and supports leader election. If Kubernetes 1.13 support is needed, you would need to stick with v0.2.0 and remove the leader election arguments.

[yanis-corselle]

Unfortunately, it is not possible as these old versions aren't available anymore ...

[ofek]

Thanks a lot!

[hweissig]

Thank you for this fix. We started running into the same errors.

Will this be tagged as a release soon? We currently are using a workaround with a forked repo of this.

[ofek]

I'm open to releasing soon but would you mind sharing which changes from your fork are required?

[hweissig]

All I did was tag the latest master and instead of kubectl apply -k "github.com/ofek/csi-gcs/deploy/overlays/stable?ref=v0.9.0" we are now using kubectl apply -k "github.com/hweissig/csi-gcs/deploy/overlays/stable?ref=v0.1o.0" for the time being.

[ofek]

Thanks! Can you please guide me on what other versions need updating in this repo? I have limited time but would like to release this week and I don't want to miss anything important that needs doing.

[hweissig]

I am afraid that is beyond my expertise, unfortunately. I see that the current release is quite far behind on the GCS fuse version as well as many of the tools, but I wouldn't know where to start with upgrading any of them.

For our purposes, just tagging the current master was enough in order to pull the images from the correct artifact repository based on the fix from @yanis-corselle.