Add era5 examples as python scripts #61
Conversation
| from feedinlib.era5 import weather_df_from_era5 | ||
|
|
||
|
|
||
| def processing_multi_locations(): |
There was a problem hiding this comment.
I would call the function processing_multiple_locations. Same goes for the file name which I would change to ..._multiple_locations.py.
| ) | ||
|
|
||
|
|
||
| def download_era5_multiprocessing_examples(): |
There was a problem hiding this comment.
I find the function name confusing. It sounds like the examples are downloaded in the function. I would either just call it download_era5_multiprocessing or download_era5_multiprocessing_example.
There was a problem hiding this comment.
If I get it right, this is parallel download rather than "multi processing", am I right?
| "cdsapi >= 0.1.4", | ||
| "geopandas", | ||
| "numpy >= 1.17.0", | ||
| "oedialect >= 0.0.6.dev0", |
There was a problem hiding this comment.
I think the oedialect is needed to download open_FRED weather data. Shouldn't we keep this as a requirement? I see the weather data download as an essential functionality of the feedinlib.
|
Thank you @uvchik for picking up work on the feedinlib again and adding new functionality to the examples, especially the multiprocessing parts which are quite useful. However, I think we need to discuss whether we want to provide example notebooks or python files, because in my opinion having both leads to an unnecessary maintenance overhead. |
| ) | ||
|
|
||
|
|
||
| def download_era5_multiprocessing_examples(): |
There was a problem hiding this comment.
If I get it right, this is parallel download rather than "multi processing", am I right?
| from feedinlib.era5 import weather_df_from_era5 | ||
|
|
||
|
|
||
| def processing_multi_locations(): |
| "start_date": "2017-01-01", | ||
| "end_date": "2017-12-31", |
There was a problem hiding this comment.
At the top, you talk about time zones. Maybe go from 2016-12-21 to 2018-01-01 to emphasize that point.
Add Python examples