Skip to content

Conversation

@jnettels
Copy link
Contributor

@jnettels jnettels commented Dec 2, 2025

A hardcoded number of minutes per year prevented leap years from being constructed properly. This is fixed by using the hoy. Also there was a test test_leap_year(), but it did not actually test a leap year.
This should fix those issues.

@jnettels jnettels self-assigned this Dec 2, 2025
@jnettels jnettels changed the title Fix/vdi leap year Fix leap year handling in VDI Dec 2, 2025
Copy link
Member

@p-snft p-snft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

PS: You might want to add this to the changelog.

@jnettels
Copy link
Contributor Author

Hi, should I update CHANGELOG.rst within this PR? Or should I do a new PR with the changes for both of my approved PRs, to avoid the merge conflict that would probably happen if I update the changelog within both PRs? Thanks

@p-snft
Copy link
Member

p-snft commented Dec 18, 2025

Hi, should I update CHANGELOG.rst within this PR? Or should I do a new PR with the changes for both of my approved PRs, to avoid the merge conflict that would probably happen if I update the changelog within both PRs? Thanks

Every PR with significant changes should include a documentation in the changelog. (Yes, that means that you have to resolve conflicts from time to time, but in this case it should just be "accept both".)

@jnettels jnettels merged commit d3db2bb into dev Dec 18, 2025
6 checks passed
@jnettels
Copy link
Contributor Author

Ok thanks, seems like "accept both" worked just fine.

@jnettels jnettels deleted the fix/vdi-leap-year branch December 18, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants