This repository was archived by the owner on Jan 31, 2019. It is now read-only.
upstream nodejs #353
Open
upstream nodejs #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a shared libv8 for nodejs puts a hard requirement on the version of libv8, which conflicts with the version used in mongodb, thus refraining us from updating to a recent nodejs. Enable the bundled libv8 to be able to update nodejs.
When copying the regex from the OE/Yocto recipe, it expected the match to be at the end of the string. Instead, we want to search the entire string for a match, so remove the remaining $'s.
Building hipster software like nodejs for win/mingw on a linux host is like pure magic, but we do the attempt anyways. And we do this because we need the nodejs-source package for the sdk, so the recipe fails if the nodejs binary doesn't build. Fix the build by splitting out a few libraries (c-ares, libuv), disabling some features (perfctr, etw, dtrace), and by patching the source in a few places. (But only patch it when building for mingw).
The final linker step failed when compiling node, which was caused by unresolved symbols from libdl. Fix this by patching gyp to link with libdl on posix systems.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.