Open
Conversation
|
@ageficent Are you sure? I tested this extensively, over many templates. Can you give me any steps to reproduce it not working. |
Author
|
I'm on holiday but I'm going to need to check it when I get back. I did
basically the same steps and in every case the debranding applied.
…On Tue, 8 Jan 2019, 9:23 PM Adria Gil Sorribes, ***@***.***> wrote:
In my case I followed the next steps to test the module:
1. Install the module
2. Configure outgoing mail server with my gmail account
3. Send a message from the contact view (see result)
[image: image]
<https://user-images.githubusercontent.com/44768500/50818007-fd8b6700-1325-11e9-9763-9f98965d47d1.png>
4. Send a quotation to my mail from the sales module (see result)
[image: image]
<https://user-images.githubusercontent.com/44768500/50818068-26136100-1326-11e9-8f19-90b9a81fce98.png>
In your code you introduce some changes in the render_post_process
function which in my case is only called to create the widget that allows
you to choose the template and change the mail body. This function is not
called when the email is actually sent (and the template is applied) and
thus, the branding is not removed.
I don't know if I have explained myself, let me know if you have any
question or if I have missed any configuration step or misunderstood
something.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE23kFNH6Lmj4RVEv3DLDl1WXmhGpUQGks5vBFWXgaJpZM4Zp3ci>
.
|
26274b0 to
c706391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I tried the module and it didn't work for me, it did not remove the Odoo branding. After some research I came across this solution.
Hope it helps.