[ADD] .*: data improvements & tax fixes #1604
Conversation
|
|
chga-odoo
changed the title
micro_brewery/__manifest__.py
Outdated
There was a problem hiding this comment.
Could you bump the version
chga-odoo
force-pushed
the
saas-19.1-update-micro-brewery-chga
branch
2 times, most recently
from
d302b8f to
909cd6f
Compare
|
Hello @vava-odoo |
vava-odoo
left a comment
vava-odoo
left a comment
There was a problem hiding this comment.
Thanks, please see my comments below. Please also retarget to 19.0
| @@ -11,54 +11,62 @@ | |||
| <field name="name">DEP 0.1</field> | |||
| <field name="type_tax_use">sale</field> | |||
| <field name="tax_group_id" ref="deposit_tax_group"/> | |||
| <field name="ubl_cii_tax_category_code">O</field> | |||
There was a problem hiding this comment.
This field is defined in account_edi_ubl_cii, which is not in the dependency tree of this industry. It probably is installed with l10n, but none is provided by default. Could you explain why it works here? And why it would in SaaS databases?
Other way would be to write only if the module is installed.
There was a problem hiding this comment.
account_edi_ubl_cii is in dependency tree of this industry(excise and deposit). that's why its work here and according to task requirement, category code added here in both module excise and deposit.
| @@ -15,6 +15,7 @@ | |||
| <field name="amount">0</field> | |||
| <field name="type_tax_use">sale</field> | |||
| <field name="tax_group_id" ref="excises_tax_group"/> | |||
| <field name="ubl_cii_tax_category_code">Z</field> | |||
There was a problem hiding this comment.
I wonder: should the "no excises" tax be visible? Maybe to discuss with Pierre to be sure
There was a problem hiding this comment.
@vava-odoo & @chga-odoo
if we could i'd like it to be removed / hidden
however to my understanding the mapping of taxes based on fiscal position makes a replacement to a tax, not to a void
therefore if there is any other way i'm in, on the SOL and INVL as well as the tax group if no other excise tax apply
| @@ -42,4 +42,20 @@ | |||
| <field name="team_id" ref="quality.quality_alert_team0"/> | |||
| <field name="picking_type_ids" model="stock.warehouse" eval="[(4, obj().env.ref('stock.warehouse0').manu_type_id.id)]"/> | |||
| </record> | |||
| <record id="quality_point_8" model="quality.point"> | |||
chga-odoo
force-pushed
the
saas-19.1-update-micro-brewery-chga
branch
from
909cd6f to
2fb1d4f
Compare
- Improved Industry data and dependencies (quality) - Moved Brown Beer and Lager Beer to Brewed category - Added pH control QCP to data - Enabled purchase for keg 20L products and set bottler vendor price to 20 - Added tax category code Z to excise taxes - Added tax category code O to deposit taxes Task ID: 5782423
chga-odoo
force-pushed
the
saas-19.1-update-micro-brewery-chga
branch
from
2fb1d4f to
698826f
Compare
5 participants
Task ID: 5782423