[ADD] convert_mo: Multiple industries module #1528
Open
+1,670
−797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
chga-odoo
force-pushed
the
19.0-convert-mo-chga
branch
9 times, most recently
from
80e5c01 to
78d3b09
Compare
- Take full control of inventory transitions. This module enables you to reclassify products and adjust grades seamlessly, ensuring total traceability for every Lot and Serial Number. - Effortless Downgrading: Instantly reassign a Lot from "Grade 1" to "Grade 2" during inventory adjustments while maintaining a comprehensive audit trail. - Product Adaptation: Pivot quickly by triggering a product change or reclassification immediately following a quality inspection. - Post-Production Flexibility: If output no longer meets its primary purpose, you can convert units into a secondary product—even after the production order is closed. Task- 5362405
Add convert_mo in depends to add feature of conversion Update knowledge article for conversion functionality Task- 5362405
chga-odoo
force-pushed
the
19.0-convert-mo-chga
branch
from
78d3b09 to
f54790e
Compare
pgu-odoo
reviewed
Jan 29, 2026
Contributor
pgu-odoo
left a comment
pgu-odoo
left a comment
There was a problem hiding this comment.
@chga-odoo here are a few remarks. But still in progress.
| <field name="model_id" ref="x_model_convert_product_wizard"/> | ||
| <field name="state">code</field> | ||
| <field name="code"><![CDATA[ | ||
| wizard = records[0] |
Contributor
There was a problem hiding this comment.
Why processing only 1 record? instead of having a for loop?
Contributor
Author
There was a problem hiding this comment.
Yes, It should be a loop. 😊
Comment on lines
18
to
19
| 'location_src_id': wizard.x_quant_id.location_id.id, | ||
| 'location_dest_id': wizard.x_quant_id.location_id.id, |
Contributor
There was a problem hiding this comment.
are you sure? source and destination locations are same?
Contributor
Author
There was a problem hiding this comment.
Yes It is a requirement of task 😊
| 'location_dest_id': wizard.x_quant_id.location_id.id, | ||
| 'origin': move.reference or move.picking_id.name if move else wizard.x_quant_id.display_name, | ||
| 'user_id': env.user.id, | ||
| 'bom_id': False, |
Contributor
There was a problem hiding this comment.
Suggested change
| 'bom_id': False, |
Contributor
Author
There was a problem hiding this comment.
It is necessary because bom_id always NULL for conversion MO
| lot_name = False | ||
| if wizard.x_keep_lot_sn: | ||
| lot_name = wizard.x_quant_id.lot_id.name | ||
| elif not wizard.x_keep_lot_sn and wizard.x_new_lot_sn: |
Contributor
There was a problem hiding this comment.
Suggested change
| elif not wizard.x_keep_lot_sn and wizard.x_new_lot_sn: | |
| elif wizard.x_new_lot_sn: |
elif will run only if wizard.x_keep_lot_sn is false.
Comment on lines
52
to
77
| if move: | ||
| mo.message_post( | ||
| body=( | ||
| 'Manufacturing Order created from Convert action in this operation: ' | ||
| '<a href="/odoo" data-oe-id="%i" data-oe-model="stock.picking" >%s</a>' | ||
| % (move.picking_id.id, move.picking_id.name) | ||
| ), | ||
| body_is_html=True | ||
| ) | ||
| move.picking_id.message_post( | ||
| body=( | ||
| f'<b>{move.product_id.display_name}</b> from location <b>{move.location_id.display_name}</b> converted into <b>{wizard.x_product_convert_into.display_name}</b> in Manufacturing Order ' | ||
| '<a href="/odoo" data-oe-id="%i" data-oe-model="mrp.production" >%s</a>' | ||
| % (mo.id, mo.name) | ||
| ), | ||
| body_is_html=True | ||
| ) | ||
| else: | ||
| mo.message_post( | ||
| body=( | ||
| 'Manufacturing Order created from Convert action in this Physical Inventory: ' | ||
| '<a href="/odoo" data-oe-id="%i" data-oe-model="stock.quant" >%s</a>' | ||
| % (wizard.x_quant_id.id, wizard.x_quant_id.display_name) | ||
| ), | ||
| body_is_html=True | ||
| ) |
Contributor
There was a problem hiding this comment.
you can avoid the duplicate code like -
model, rec_id, name, label = (
("stock.picking", move.picking_id.id, move.picking_id.name, "operation")
if move
else ("stock.quant", wizard.x_quant_id.id, wizard.x_quant_id.display_name, "Physical Inventory")
)
mo.message_post(
body=(
f'Manufacturing Order created from Convert action in this {label}: '
'<a href="/odoo" data-oe-id="%i" data-oe-model="%s">%s</a>'
% (rec_id, model, name)
),
body_is_html=True,
)
if move:
move.picking_id.message_post(
body=(
'<b>%s</b> from location <b>%s</b> converted into <b>%s</b> in Manufacturing Order '
'<a href="/odoo" data-oe-id="%i" data-oe-model="mrp.production">%s</a>'
% (
move.product_id.display_name,
move.location_id.display_name,
wizard.x_product_convert_into.display_name,
mo.id,
mo.name,
)
),
body_is_html=True,
)
convert_mo/data/ir_model_fields.xml
Outdated
| <field name="ttype">boolean</field> | ||
| </record> | ||
| <record id="x_show_convert_visible_field_stock_picking" model="ir.model.fields"> | ||
| <field name="name">x_show_convert_visible</field> |
Contributor
There was a problem hiding this comment.
Suggested change
| <field name="name">x_show_convert_visible</field> | |
| <field name="name">x_show_convert</field> |
or is can be x_can_convert also.
convert_mo/data/ir_model_fields.xml
Outdated
Comment on lines
49
to
51
| for wizard in self: | ||
| move_line = wizard.x_move_id.move_line_ids[:1] | ||
| wizard['x_quant_id'] = move_line and self.env['stock.quant'].search([('product_id', '=', move_line.product_id.id), ('location_id', '=', move_line.location_id.id), ('lot_id', '=', move_line.lot_id.id)], limit=1) or False |
Contributor
There was a problem hiding this comment.
can also be written as to have safe checks -
for wizard in self:
wizard.x_quant_id = False
if wizard.x_move_id and wizard.x_move_id.move_line_ids:
move_line = wizard.x_move_id.move_line_ids[:1]
wizard['x_quant_id'] = self.env['stock.quant'].search([('product_id', '=', move_line.product_id.id), ('location_id', '=', move_line.location_id.id), ('lot_id', '=', move_line.lot_id.id)], limit=1)
convert_mo/data/ir_ui_view.xml
Outdated
| <field name="arch" type="xml"> | ||
| <xpath expr="//list/field[@name='forecast_availability']" position="after"> | ||
| <button name="%(action_convert_product_wizard)d" | ||
| string="convert" |
Contributor
There was a problem hiding this comment.
Suggested change
| string="convert" | |
| string="Convert" |
convert_mo/data/ir_ui_view.xml
Outdated
| <list string="Convert Products" create="false" edit="false" delete="false"> | ||
| <field name="display_name" string="Product Display Name"/> | ||
| <field name="is_storable" string="Is Storable ?"/> | ||
| <field name="tracking" string="Trace by"/> |
Contributor
There was a problem hiding this comment.
Suggested change
| <field name="tracking" string="Trace by"/> | |
| <field name="tracking" string="Trace By"/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Conversion & Grading Management
Purpose
Task- 5362405