19.0 matchmaking real estate update frva #1514

frva-odoo · 2026-01-07T15:19:35Z

No description provided.

robodoo · 2026-01-07T15:19:41Z

dhrs-odoo

Hello @frva-odoo
Thanks for the good work
Just few comments as of now 😇

real_estate/data/product_attribute_post.xml

real_estate/demo/product_attribute_value.xml

dhrs-odoo · 2026-01-21T06:58:08Z

You also need to update the POT file

vava-odoo

Good work!
Please squash your commits while resolving the comments :-)

vava-odoo · 2026-01-27T09:20:07Z

real_estate/demo/product_template_attribute_line.xml

        <field name="sequence">15</field>
-        <field name="attribute_id" ref="product_attribute_15"/>
-        <field name="value_ids" eval="[(6, 0, [ref('product_attribute_value_15')])]"/>
+        <field name="attribute_id" ref="product_attribute_17"/>


I wonder if we shouldn't change the xmlid of this record, because it is marked as noupdate.
You could try the behaviour: install previous version and try to upgrade with new version and see how the products are.
That being said, it can be ok, since these are demo data, so we are not supposed to upgrade them.

You were right, it brings an issue when updating if we install the new version while changing those records.

vava-odoo · 2026-01-27T09:21:27Z

real_estate/demo/product_template_attribute_value.xml

    </record>
    <record id="product_template_attribute_value_6" model="product.template.attribute.value">
-        <field name="product_attribute_value_id" ref="product_attribute_value_15"/>
+        <field name="product_attribute_value_id" ref="product_attribute_value_26"/>


vava-odoo · 2026-01-27T09:25:01Z

real_estate/data/ir_model_fields.xml

        ]]></field>
        <field name="ttype">many2many</field>
-        <field name="depends">x_categories_ids, x_region_ids, x_type, x_condition_ids, x_min_price, x_max_price</field>
+        <field name="depends">x_categories_ids, x_criteria_ids, x_min_price, x_max_price</field>


the compute can probably be edited as well

vava-odoo · 2026-01-27T09:25:47Z

real_estate/data/ir_ui_menu.xml

    <menuitem id="crm_sellers_menu" name="Sellers" action="owners_act_window" sequence="1" parent="crm.crm_menu_sales"/>
    <record id="properties_menu_root" model="ir.ui.menu">
-        <field name="web_icon_data" type="base64" file="real_estate/static/description/icon_no_border.png"/>
+        <field name="web_icon_data" type="base64" file="real_estate/static/description/icon.png"/>


this will conflict with a recent change

vava-odoo · 2026-01-27T09:26:31Z

real_estate/data/ir_ui_view.xml

+    <field name="priority">200</field>
+    <field name="type">search</field>
+    <field name="arch" type="xml">
+        <search string="Search Partner">


partner 🧐

vava-odoo · 2026-01-27T09:27:16Z

real_estate/data/ir_ui_view.xml

    ]"/>
  </record>
+  <record id="product_attribute_form_view_extended" model="ir.ui.view">
+    <field name="name">product.attribute.form customization</field>


Suggested change

<field name="name">product.attribute.form customization</field>

<field name="name">product.attribute.form.inherit.real_estate</field>

vava-odoo · 2026-01-27T09:32:56Z

real_estate/data/website_view.xml

+                            </label>
+                            <div class="row s_col_no_resize s_col_no_bgcolor s_website_form_multiple" data-name="x_criteria_ids" data-display="vertical">
+                                <t t-set="attr_values" t-value="request.env['product.attribute.value'].search([('attribute_id', '=', attr.id)])"/>
+                                <t t-foreach="attr_values" t-as="attr">


maybe use another variable name than attr which is already use for the attribute

vava-odoo · 2026-01-27T09:36:52Z

real_estate/data/website_view.xml

-                                        t-att-for="'condition_attrs_values' + str(condition.id)">
-                                    <t t-out="condition.name"/>
-                                  </label>
+                        <t t-foreach="request.env['product.attribute'].search([('x_is_matchmaking', '!=', False)])" t-as="attr">


I usually see limits added to the search. Is there any performance issue to fear here?

I removed the second search inside so we could have better performances, but I don't think we want to limit the amount of attributes that can be displayed in the website form, or if we do I don't know how many we can have (at least limit=20 I guess).
Anyway I think it is optimized enough to have no issue right now, tell me if you think we should improve further

This commit improves the matchmaking on both the frontend and backend. The partners now have a single field "Criterias" to manage the attributes values for each matchmaking product attribute value. The website template view of the matchmaking is changed, made to take every product attribute we want instead of hardcoding every single one. Product attributes have now a field "Matchmaking", marking them and their values to be used in the previous cases. It also moves the "Region" product attribute values in demo, adds an attribute menu in the real_estate app and removes one of the "Bathroom" attributes to avoid redundancy. Task-5143951

frva-odoo force-pushed the saas-19.1-matchmaking-real-estate-update-frva branch 3 times, most recently from e94dae8 to f1d7049 Compare January 12, 2026 12:58

frva-odoo changed the base branch from saas-19.1 to 19.0 January 12, 2026 12:59

frva-odoo changed the title ~~Saas 19.1 matchmaking real estate update frva~~ 19.0 matchmaking real estate update frva Jan 12, 2026

frva-odoo force-pushed the saas-19.1-matchmaking-real-estate-update-frva branch 2 times, most recently from 3a731b8 to 25200a2 Compare January 20, 2026 15:18

dhrs-odoo requested changes Jan 21, 2026

View reviewed changes

real_estate/data/product_attribute_post.xml Outdated Show resolved Hide resolved

real_estate/demo/product_attribute_value.xml Show resolved Hide resolved

frva-odoo force-pushed the saas-19.1-matchmaking-real-estate-update-frva branch 2 times, most recently from 27cc737 to d890050 Compare January 21, 2026 12:43

frva-odoo marked this pull request as ready for review January 21, 2026 12:47

vava-odoo reviewed Jan 27, 2026

View reviewed changes

frva-odoo force-pushed the saas-19.1-matchmaking-real-estate-update-frva branch from d890050 to 9f53594 Compare January 30, 2026 10:35

frva-odoo force-pushed the saas-19.1-matchmaking-real-estate-update-frva branch from 9f53594 to a26ea7e Compare January 30, 2026 10:37

	<field name="name">product.attribute.form customization</field>
	<field name="name">product.attribute.form.inherit.real_estate</field>

19.0 matchmaking real estate update frva #1514

Are you sure you want to change the base?

19.0 matchmaking real estate update frva #1514

Conversation

frva-odoo commented Jan 7, 2026

Uh oh!

robodoo commented Jan 7, 2026

Uh oh!

dhrs-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dhrs-odoo commented Jan 21, 2026

Uh oh!

vava-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants