[ADD] construction_remarks: new construction submodule #1428
+1,216
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
trcazier
force-pushed
the
19.0-construction-remarks-spec-trcaz
branch
from
1570e24 to
ac48936
Compare
trcazier
force-pushed
the
19.0-construction-remarks-spec-trcaz
branch
3 times, most recently
from
d042317 to
fb96d05
Compare
trcazier
force-pushed
the
19.0-construction-remarks-spec-trcaz
branch
from
ed68032 to
6e8f3c6
Compare
This commit is part of a 2-part task (task-5148878). This commit adds the module, and the other updates the knowledge article and the setting to enable this submodule. This commit adds a new construction submodule, enabling the user to create remarks for projects, projects updates, and meetings (calendar.event), a menu to access them, and a button in the project top bar to access the project's remarks. task-5358871
- create JS patch to fix groupby stage_id showing all stages - fix stage_id not being initialized from one2many - fix reference not initializing properly when creating multiple at the same time (moved computed field to server action) - fix wrong views for embedded action
- Add description tab to remark form - Add a quick create view for remark kanban - Add remark kanban - Fix top bar not showing - Fix embedded action buttons not functioning properly - Try a fix for the group_expand
- order remarks by ascending references - remove remark demo stage names - compactify JS Remark images: - remove video attachments & fields & remove video tab - make image full width in form - make thumbnails smaller - fix thumbnail delete button not working - fix image edit not working because of hardcoded JS field
- removed remarks from My Tasks
- remove default x_stage_id everywhere. Instead, adds logic to pick one from the project's remark stages on write if no stage is selected - finally fix the wrong stages appearing in task & remark kanban each time a new remark is created - add the "Add Stage" button on the right of the kanban to quick create remark stages from the kanban - move JS patches from separate files to one to save lines
This commit converts the embedded action server action back to a regular window action now that the default stage logic has changed and that we don't need a ref AND active_id at the same time in the context anymore. This also reduces the cloc. Also removes all the context variables that were only there to make the server action work as an embedded action.
Entirely replace the remark image model with the chatter attachments - opens the attachment view by default on the remark form view to allow for easy attachment of remark pictures - completely removed the remark image model, fields, defaults & view - in the image form, completely removed JS & CSS associated with the image field & its widget
- add color column to remark categories list - rename act_window id of remarks kanban view - hide partner_id in remarks kanban view - reduce server_action cloc
savp's review 4.2
The arrows in the upper right corner didn't work when clicking on a remark
…ta create added missing trigger_field_ids on the x_stage_id
trcazier
force-pushed
the
19.0-construction-remarks-spec-trcaz
branch
from
e74fb6a to
2a5e27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is part of a 2-part task (task-5148878). This commit adds the module, and the other updates the knowledge article and the setting to enable this submodule.
This commit adds a new construction submodule, enabling the user to create remarks for projects, projects updates, and meetings (calendar.event), a menu to access them, and a button in the project top bar to access the project's remarks.
task-5358871