19.0 condominium industry update mega

[mega-odoo]

Purpose: Rework of the industry based on feedback, as well as to generate more traction on the combo of industries real estate, estate management, and condominium

This commit adds new features to the condominium module, including managing co-ownership properties, Split analytic items in case of owner change, general meeting animation with votes, delegation, and report, and improving the report for the general meetings agenda and report. Added Building tab and fields to the contact form, captures the history of owners and tenants

Rework on Contacts, Condominium app, Accounts, Calendar events, Invoices, Distribution key, and Automations

TASK-4743607

[robodoo]

[pgu-odoo]

@mega-odoo Huge great work!
I will wait for your commit to resume review.

Thanks!

[pgu-odoo]

Suggested change

'account_peppol',

I think it is auto installed for a few countries.

[pgu-odoo]

original_analytic is used before assigned. If line.x_analytic_line_id is false, it will raise error.

[pgu-odoo]

Suggested change

	for original_id, new_lines in occupied_cells.items():
	for new_analytic_line in list(new_lines):
	for Aid, values in note_details.items():
	if original_id == Aid:
	note_html = f"""
	<i>{datetime.date.today().strftime("%d %B %Y")}</i><br/>
	<p><b>Analytic item coming from a split</b><br/>
	{'<br/>'.join(list(values))}<br/>
	See <a href='/odoo/analytic-items/{original_id}' target='_blank'> original analytic item</a>
	</p>
	"""
	new_analytic_line.write({"x_notes": note_html.strip()})
	for original_id, new_lines in occupied_cells.items():
	values = note_details.get(original_id)
	if not values:
	continue
	note_html = f"""
	<i>{datetime.date.today().strftime("%d %B %Y")}</i><br/>
	<p><b>Analytic item coming from a split</b><br/>
	{'<br/>'.join(list(values))}<br/>
	See <a href='/odoo/analytic-items/{original_id}' target='_blank'> original analytic item</a>
	</p>
	"""
	for new_analytic_line in new_lines:
	new_analytic_line.write({"x_notes": note_html})

Can't be improve like this?

[pgu-odoo]

You are browsing the record twice. new_analytic_item.browse(original_id)

[pgu-odoo]

Suggested change

	fname: analytic_id.id or '',
	fname: analytic_id.id or False

or

Suggested change

	fname: analytic_id.id or '',
	fname: analytic_id.id,

because if analytic_id is false then analytic_id.id will also b false.

[pgu-odoo]

Suggested change

	if total_distribution == 0: raise UserError("Cannot split the Sales Orders because there is not distribution key total is null.")
	if total_distribution == 0: raise UserError("Cannot split the Sales Orders because there is no distribution key and total is null.")

[pgu-odoo]

Suggested change

	new_so = record.copy(); new_so_lines = [];
	new_so = record.copy({'order_line': False}); new_so_lines = [];

[pgu-odoo]

new_so.write({
    'x_source_sales_order': record.id,
    'partner_id': owner.id,
})

[pgu-odoo]

Suggested change

new_so.order_line.unlink() # Remove the lines that were copied from the source SO

If unset during copying, there will be no need of it.

[pgu-odoo]

The whole method can be improved, to avoid create in for loop.

analytic = env['account.analytic.account']
accounts_to_create = []

for line in record.x_property_id.x_owner_ids:
    if not line.x_end_date:
        record.x_property_id.write({'x_current_owner': line.x_owner.id})
    if line.x_owner:
        existing = Analytic.search([
        ('x_property', '=', record.x_property_id.id),
        ('partner_id', '=', line.x_owner.id)
        ], limit=1)

    if not existing:
        accounts_to_create.append({
        'name': f"{record.x_property_id.x_name} - {line.x_owner.name}",
        'x_property': record.x_property_id.id,
        'partner_id': line.x_owner.id,
        'x_owner_line': line.id,
        })
    if accounts_to_create:
        new_accounts = Analytic.create(accounts_to_create)

[pgu-odoo]

@mega-odoo A few suggestions are here. Thanks.

[pgu-odoo]

Suggested change

owner_id = owner.id

use owner.id whenever needed.

[pgu-odoo]

Instead of search_count in for loop. You can user read_group method.

[pgu-odoo]

same as above. Using read_group is better.

[pgu-odoo]

what if search returns multiple analytic accounts? accounts.id will break.
if you want only one analytic account, use the limit=1 in search and change the name account from accounts.
if expecting multiple, then handle the assignation proper.

[pgu-odoo]

for record in self:
    record.x_is_distributed = any(
        bool(line.analytic_distribution)
        for line in record.invoice_line_ids
    )

would be better

[pgu-odoo]

Suggested change

	<field optional="show" name="x_account" options="{&quot;no_create&quot;:true}" readonly="True" widget="many2one_tax_tags" column_invisible="True"/>
	<field optional="show" name="x_account" options="{'no_create':true}" readonly="True" widget="many2one_tax_tags" column_invisible="True"/>

[pgu-odoo]

if it is required, we should not put it in optional="show"

[pgu-odoo]

Suggested change

	<record id="default_search_view__357f8b9e-0127-48a6-97ac-45ad1fce0030" model="ir.ui.view">
	<record id="default_search_view" model="ir.ui.view">

[pgu-odoo]

Suggested change

	<button string="Populate" name="%(action_populate_distribution_key)d" type="action" class="btn-primary" invisible="x_based_on != &quot;Shares&quot;"/>
	<button string="Populate" name="%(action_populate_distribution_key)d" type="action" class="btn-primary" invisible="x_based_on != 'Shares'"/>

[pgu-odoo]

is it needed?

[pgu-odoo]

@vava-odoo I have given a few suggestions and @mega-odoo is working with those but I think meanwhile you can also start the code review for this PR.

Thanks