Skip to content

Conversation

@lman-odoo
Copy link
Contributor

task-5136241

@robodoo
Copy link
Collaborator

robodoo commented Dec 3, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team December 3, 2025 12:45
@lman-odoo lman-odoo requested review from auva-odoo and removed request for a team December 3, 2025 13:10
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is only the first of two comment batches for this review! But thank you so much already for your tremendous work in this PR 🤯 🙏 !!!)

  • I think it might better (and easier) to structure the beginning of the doc a bit differently to have something that's maybe a bit closer to the options available in the Style tab. I think it would make things easier to understand, and also, for example, the search field/option also controls whether the search field is displayed at the top of the filters so it's not limited tot the "top bar". I would also rename "top bar" into "toolbar" and would maybe have something like this: (h2) Toolbar and filters (let's see if this works!) and then h3s: Categories, Filters, Toolbar. Let's maybe discuss this!

  • As discussed, let's also add a seealso for the Gelato documentation saying something like: Configure the Gelato connector in Odoo to synchronize product catalogs and automate order fulfilment with Gelato.

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: sorry it seems I have posted the same comment twice and I can no longer delete my own comments (thank you GitHub ...), I can only edit it. Please ignore this one!

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lman-odoo, here's the second (and last) part of this first review. Thank you for your patience! As usual, feel free to reach out if anything's unclear or if you'd like to discuss any of my comments/questions!

(PS: Don't forget to avoid you/your when possible (e.g., your website, your products, etc.))

@lman-odoo lman-odoo force-pushed the 19.0-ecommerce-catalog-lman branch from b497ea4 to b14b5d9 Compare December 11, 2025 08:42
@lman-odoo lman-odoo requested a review from auva-odoo December 11, 2025 10:04
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the changes @lman-odoo and good job restructuring the catalog doc page! I have only minor comments mostly, we should be good after this review 🙂

Also, could we please uniformize the way we write ecommerce (in this PR at first and then keep it in mind for the rest of the doc): basically, imo: eCommerce ONLY if we're talking about the app or something in the UI because it's the way they spelled it; for other applications, choose between e-commerce and ecommerce 🙂 --> we can of course discuss this but in any case, i would uniformize!)

@lman-odoo lman-odoo force-pushed the 19.0-ecommerce-catalog-lman branch from b14b5d9 to 2768485 Compare December 16, 2025 08:19
@lman-odoo lman-odoo force-pushed the 19.0-ecommerce-catalog-lman branch from 2768485 to 03a34c2 Compare December 16, 2025 08:27
@lman-odoo lman-odoo requested review from auva-odoo and removed request for a team December 16, 2025 08:57
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @lman-odoo, thank you for your patience and hard work! 😊

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 17, 2025
task-5136241

closes #15569

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
robodoo pushed a commit that referenced this pull request Dec 17, 2025
task-5136241

closes #15569

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
robodoo pushed a commit that referenced this pull request Dec 17, 2025
task-5136241

closes #15569

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@robodoo robodoo closed this in ffea780 Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants