-
Notifications
You must be signed in to change notification settings - Fork 118
[IMP] i10n_es: add new assets model #5006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0-l10n_es-accounting-onboarding-malb
Are you sure you want to change the base?
[IMP] i10n_es: add new assets model #5006
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:19.0-l10n_es-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, just two comments ! 😄
| "asset_motor_vehicles","a352000","281800","681000","Motor vehicles","4","12" | ||
| "asset_other_property_plant_equipment","a352100","281900","681000","Other property, plant and equipment","5","12" | ||
| "asset_investments_in_buildings","a352200","282000","682000","BInvestments in buildings","30","12" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra line for no reason 👀
| "asset_development","a322000","280000","680000","Development ","5","12" | ||
| "asset_administrative_concessions","a323000","280000","682000","Administrative concessions","5","12" | ||
| "asset_industrial_property","a330000","280000","682000","Industrial property","10","12" | ||
| "asset_goodwill","a340000","280000","682000","Goodwill","10","12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodwill should be in another account.asset file 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acknowledged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this one then 😄 Don't forget to remove it also from the common account.account
ba2093d to
d64c964
Compare
malb-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things 😄
| @@ -0,0 +1,19 @@ | |||
| "id","account_asset_id","account_depreciation_id","account_depreciation_expense_id","name","method_number","method_period" | |||
| "asset_research","a315000","280000","680000","Research","5","12" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for account_depreciation_id and account_depreciation_expense_id you added the number, but it should be the id of the account 👀
| "asset_development","a322000","280000","680000","Development ","5","12" | ||
| "asset_administrative_concessions","a323000","280000","682000","Administrative concessions","5","12" | ||
| "asset_industrial_property","a330000","280000","682000","Industrial property","10","12" | ||
| "asset_goodwill","a340000","280000","682000","Goodwill","10","12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this one then 😄 Don't forget to remove it also from the common account.account
New assets model created and related to accounts es_common and es_full task - 5867581
d64c964 to
504a8b1
Compare
New spanish assets model created and related to accounts es_common and es_full
task - 5867581