[FIX] hr_holiday: prevent accrual day selection of invalid days (e.g Feb 31st) via new widget #4987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, Feb 31st) via new widget Steps to reproduce: Open accrual milstone form containing the custom day selection field. Select "February" as the month and observe that "31" remains a selectable option in the day dropdown. Bug Cause: The standard selection field used static values (1-31) and lacked dynamic cross-field validation between the month and day inputs. Solution: Created a new Odoo field widget to handle day selection. This widget dynamically calculates the maximum number of days allowed based on the selected month and year, effectively disabling or removing invalid dates like February 31st.
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-vikri, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce: Open accrual milstone form containing the custom day selection field. Select "February" as the month and observe that "31" remains a selectable option in the day dropdown.
Bug Cause: The standard selection field used static values (1-31) and lacked dynamic cross-field validation between the month and day inputs.
Solution: Created a new Odoo field widget to handle day selection. This widget dynamically calculates the maximum number of days allowed based on the selected month and year, effectively disabling or removing invalid dates like February 31st.