[IMP] l10n_es: hide simplified invoice field for non-ES companies #4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:19.0-l10n_es-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
FlorianGilbert
requested changes
Jan 26, 2026
FlorianGilbert
left a comment
FlorianGilbert
left a comment
There was a problem hiding this comment.
May I ask you to have a complete commit message where you explain what you are doing and why?
We also have to add the task id at the end of the commit message according to the guidelines.
| <field name="name">account.move.form.inherit</field> | ||
| <field name="model">account.move</field> | ||
| <field name="inherit_id" ref="account.view_move_form"/> | ||
| <field name="inherit_id" ref="account.view_move_form" /> |
There was a problem hiding this comment.
That's what we like to call useless diff. We generally try to avoid diff when it's not necessary, may I ask you to remove this?
FlorianGilbert
requested changes
Jan 26, 2026
FlorianGilbert
left a comment
FlorianGilbert
left a comment
There was a problem hiding this comment.
Ok almost good to me! May I ask you to squash your commits?
EduardD22
force-pushed
the
19.0-fix-spanish-field-eadi
branch
from
4d2d74f to
3ca2194
Compare
Before this commit, the 'l10n_es_is_simplified' field was visible on invoices for all companies, even if they were not Spanish. This commit hides the field if the company's country is not Spain. It also ensures the field is readonly when the entry is posted. Task-ID: 5867665
EduardD22
force-pushed
the
19.0-fix-spanish-field-eadi
branch
from
3ca2194 to
0a14655
Compare
FlorianGilbert
approved these changes
Jan 27, 2026
Comment on lines
+9
to
+11
| <field name="l10n_es_is_simplified" | ||
| invisible="country_code != 'ES'" | ||
| readonly="state == 'posted'" |
There was a problem hiding this comment.
I could nitpick on the alignment of attributes, but that's ok!
Suggested change
| <field name="l10n_es_is_simplified" | |
| invisible="country_code != 'ES'" | |
| readonly="state == 'posted'" | |
| <field name="l10n_es_is_simplified" | |
| invisible="country_code != 'ES'" | |
| readonly="state == 'posted'" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.