This repository was archived by the owner on Oct 9, 2018. It is now read-only.
Fix for bug "os.path.join() is used for building urls"#26
Open
Marm0t wants to merge 1 commit intoodesk:masterfrom
Marm0t:master
Open
Fix for bug "os.path.join() is used for building urls"#26Marm0t wants to merge 1 commit intoodesk:masterfrom Marm0t:master
Marm0t wants to merge 1 commit intoodesk:masterfrom
Marm0t:master
Conversation
To support Windows `os.path.join()` replaced with `posixpath.join()`
Author
...............................................................Ran 63 tests in 0.121s OK |
kipanshi
force-pushed
the
master
branch
2 times, most recently
from
4c0f144 to
86c0cad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #25
To support Windows
os.path.join()replaced withposixpath.join()in namespaces.py and oauth.py.I've replaces it with posixpath to make it easier then to adapt it for both python2 and python3 (
urlparse.urljoinshould be used in python2 andurllib.parse.urljoinfor python 3).