fix(e2e): fix React hydration error and re-enable E2E tests (#56) #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add isMounted flag to prevent localStorage access during SSR - Check typeof window to ensure client-side only execution - Prevents hydration mismatch that caused React error #423 - Fixes E2E test failures by ensuring proper client/server boundaries
- E2E tests disabled due to React error #423 (hydration mismatch) - CartContext now properly guards localStorage access for SSR - Re-enable pull_request and push triggers on dev/main branches - Tests should now pass with isMounted flag preventing SSR localStorage conflicts
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
E2E tests were failing with React error #423: 'too many re-renders'. Root cause was CartContext accessing localStorage during server-side rendering, causing hydration mismatch.
Solution
CartContext Hydration Fix
Re-enable E2E Workflow
Changes
Testing
Tests will run on this PR to verify:
Impact