fix: update inline styles to WCAG AAA compliant colors #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix (#39) only updated chat-widget.css, but the JavaScript file (chat-widget.js) was using inline styles that override the CSS. This fix updates all inline style declarations to use #0056b3 instead of #007bff for WCAG AAA compliance. Changes: - Header background: #007bff -> #0056b3 - Send button background: #007bff -> #0056b3 - User message bubbles: #007bff -> #0056b3 Contrast ratio: 3.14:1 -> 5.89:1 (WCAG AAA pass) Related: #39
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #39 fixed the CSS colors for WCAG AAA compliance (#007bff -> #0056b3), but the JavaScript file uses inline styles that override the CSS.
Solution
Updated all inline style declarations in chat-widget.js:
Testing
Contrast ratio: 3.14:1 -> 5.89:1 (WCAG AAA pass)
All inline styles now match CSS
Related
Completes fix from PR #39