Open
Conversation
In a fork, the secret is unlikely to be present. By making the project-url conditional on the secret, it'll basically never be set in forks (unless you work on octokit and happen to choose to create a secret to use for the purpose of testing -- which is unlikely). Setting github-token to `github.token` as a fallback means that the workflow will run in forks w/o triggering ❌ which is slightly better. Eventually users will still disable it because it's annoying, but only once they manage to create a PR or issue in their fork and it runs and tags it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a fork, the secret is unlikely to be present.
By making the project-url conditional on the secret, it'll basically never be set in forks (unless you work on octokit and happen to choose to create a secret to use for the purpose of testing -- which is unlikely).
Setting github-token to
github.tokenas a fallback means that the workflow will run in forks w/o triggering ❌ which is slightly better. Eventually users will still disable it because it's annoying, but only once they manage to create a PR or issue in their fork and it runs and tags it...per octokit/request.js#669 (comment)