Upgrade "js-yaml" from "~3.13.1" to "~4.1.0"#2
Merged
octogonz merged 6 commits intooctogonz/lfx-fixes2from Sep 14, 2025
Merged
Conversation
iclanton
approved these changes
Sep 14, 2025
Comment on lines
+51
to
+52
| this._snippets = yaml.load(snippetsContent, { filename: snippetsFilePath }) as ISnippetsFile; | ||
| this._snippetsAll = yaml.load(snippetsContent, { filename: snippetsFilePath }) as ISnippetsFile; |
There was a problem hiding this comment.
load isn't generic? What type does it return?
Owner
Author
There was a problem hiding this comment.
In the new version, it returns unknown instead of any which requires an explicit type cast.
Arguably as ISnippetsFile better captures the assumption/conversion happening here, versus <ISnippetsFile>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is based on my other branch from PR microsoft#5358
Rush Stack's
js-yamldependency is very old. Besides including unsafe deserialization (the classic incompetent security practice of evaling!!js/functionscripts from a data file), the newer version fixes another nonstandard behavior whereundefinedvalues get serialized as!<tag:yaml.org,2002:js/undefined> ''rather than discarded.Details
How it was tested
rush testImpacted documentation
None.