Update PHP requirement to 8.1 and remove strftime() deprecation #648
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Samuell1
commented
Jan 4, 2026
Samuell1
commented
- Bumps minimum PHP version from 8.0.2 to 8.1
- Replaces deprecated strftime() in FormBuilder::selectMonth() with DateTime::format()
- Changes default format parameter from strftime '%B' to DateTime 'F' (both output full month name)
- Bumps minimum PHP version from 8.0.2 to 8.1 - Replaces deprecated strftime() in FormBuilder::selectMonth() with DateTime::format() - Changes default format parameter from strftime '%B' to DateTime 'F' (both output full month name)
Member
|
Thanks! |
Samuell1
commented
Jan 5, 2026
|
|
||
| foreach (range(1, 12) as $month) { | ||
| $months[$month] = strftime($format, mktime(0, 0, 0, $month, 1)); | ||
| $date = new \DateTime("2024-{$month}-01"); |
Member
Author
There was a problem hiding this comment.
@daftspunk now looking at this there is year 2024 :D can this break something?
Member
There was a problem hiding this comment.
It's fine. It needs a year, even if unused...
DEPRECATED DateTime::setDate(): Passing null to parameter #1 ($year) of type int is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.