TextFilter: improve behavior for multiple filters#5567
Open
phisko wants to merge 1 commit intoocornut:masterfrom
Open
TextFilter: improve behavior for multiple filters#5567phisko wants to merge 1 commit intoocornut:masterfrom
phisko wants to merge 1 commit intoocornut:masterfrom
Conversation
PassFilter will now return true if all required ranges are found
Owner
|
Seems similar to #2435 |
Author
|
Indeed, for some reason #2435 didn't come up in my search results before implementing this, but it's a more complete version of this (although it doesn't simplify the code quite as much). From what I can see you're interested in that PR but haven't had time to take a look at it in detail. Do you have some sort of ETA for when you might? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassFilter will now return true if all required ranges are found
The current behavior is rather inconsistent: given
"Some fancy sentence"astext,PassFilterwill:trueif the filter isfancy,-sentencefalseif the filter is-sentence,fancytrueif the filter isfancy,randomFrom my experience, this isn't what end users expect when using a search filter.
This also simplifies the code, and removes the
CountGrepmechanism.