Symlink license file so it get published in the crates#31
Open
michel-slm wants to merge 1 commit intooconnor663:masterfrom
Open
Symlink license file so it get published in the crates#31michel-slm wants to merge 1 commit intooconnor663:masterfrom
michel-slm wants to merge 1 commit intooconnor663:masterfrom
Conversation
The `LICENSE` file is in the top-level repo directory, but not in each
of the crates published to `crates.io`. This means it's missing from the
packaged crates.
Symlink them into place.
```
michel in blake2_simd/blake2_bin on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
Packaging blake2_bin v1.0.2 (/home/michel/src/github/oconnor663/blake2_simd/blake2_bin)
Updating crates.io index
Packaged 7 files, 41.0KiB (11.7KiB compressed)
michel in blake2_simd/blake2_bin on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ bsdtar tf target/package/blake2_bin-1.0.2.crate | grep LICENSE
blake2_bin-1.0.2/LICENSE
michel in blake2_simd/blake2_bin on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ cd ../blake2b
michel in blake2_simd/blake2b on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
Packaging blake2b_simd v1.0.2 (/home/michel/src/github/oconnor663/blake2_simd/blake2b)
Packaged 12 files, 143.0KiB (33.9KiB compressed)
michel in blake2_simd/blake2b on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ bsdtar tf target/package/blake2b_simd-1.0.2.crate | grep LICENSE
blake2b_simd-1.0.2/LICENSE
michel in blake2_simd/blake2b on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ cd ../blake2s
michel in blake2_simd/blake2s on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ cargo package --allow-dirty --no-verify
Packaging blake2s_simd v1.0.2 (/home/michel/src/github/oconnor663/blake2_simd/blake2s)
Packaged 12 files, 143.9KiB (33.3KiB compressed)
michel in blake2_simd/blake2s on add-license [+] is 📦 v1.0.2 via 🐍 v3.11.6 (.venv311) via 🦀 v1.73.0
⬢ [fedora-toolbox:38] ❯ bsdtar tf target/package/blake2s_simd-1.0.2.crate | grep LICENSE
blake2s_simd-1.0.2/LICENSE
```
Signed-off-by: Michel Lind <salimma@fedoraproject.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LICENSEfile is in the top-level repo directory, but not in each of the crates published tocrates.io. This means it's missing from the packaged crates.Symlink them into place.