-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Partners page extraction + Phase 2 specs #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wab
wants to merge
15
commits into
main
Choose a base branch
from
clean-components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add partners-style-components.md PRD with style/content separation patterns - Add partners-implementation-plan.md with detailed implementation steps - Add stories.json with 14 feature stories for phase 2 - Introduce local style wrappers pattern (single-file, non-exported) - Define Text, IconBox, FormField atoms and compound components approach Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add text recipe to panda.config.ts with: - Variants: display-xl, display-lg, display-md, subtitle, body, label - Colors: dark, muted, muted-light, white, sky, mint, yellow, coral Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Polymorphic element: h1-h4, p, span, label - Extends TextVariantProps from text recipe - Supports className and htmlFor props Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Sizes: sm (8x8), md (10x10), lg (16x16) - Variants: solid, outline, ghost - Colors: default, sky, mint, yellow, coral - Uses compoundVariants for color combinations Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Extends IconBoxVariantProps from recipe - Props: size, variant, color, children, className Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Follows spec pattern: single-use styles should be local, not global recipes. Removes Context (unused), uses css.raw() for style composition. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
More idiomatic Panda CSS pattern with typed variant props. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…-use - Story 6: hover states in local styled() wrapper, not recipe - Add styled() pattern with variants example - Add decision table: recipe vs styled() - Remove partnerCard from global recipes list Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Phase 1 - Component extraction
Partners.tsxinto 6 section components:hero-section.tsxphilosophy-section.tsxecosystem-section.tsxpartner-card.tsxpartner-form.tsxcta-section.tsxdata/partners-data.tsatoms/index.ts,molecules/index.ts,organisms/index.ts)Phase 2 - Specs & Stories
specs/partners-style-components.md(PRD)specs/partners-implementation-plan.mdstories.jsonwith 14 feature storiesRelated Issue
Closes #18
Test plan
pnpm run build)pnpm exec tsc)pnpm test)🤖 Generated with Claude Code