Fix memory leak in radTInteraction::EmptyVectOfPtrToListsOfTrans #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that iterating starting from 1 is a simple typo here. It causes the two objects that are first in these two arrays not to be deallocated. The objects were allocated in radTInteraction::CountMainRelaxElems.
ochubar
reviewed
Dec 30, 2019
| inline void radTInteraction::EmptyVectOfPtrToListsOfTrans() | ||
| { | ||
| for(unsigned i=1; i<IntVectOfPtrToListsOfTransPtr.size(); i++) | ||
| for(unsigned i=0; i<IntVectOfPtrToListsOfTransPtr.size(); i++) |
Owner
There was a problem hiding this comment.
Nice catch. I'll make more tests / debugging, and will probably merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that iterating starting from 1 is a simple typo here. It causes the two objects that are first in these two arrays not to be deallocated.
The objects were allocated in radTInteraction::CountMainRelaxElems.
I found this with Address Sanitizer. The change removes the warning and seems to work. The change is tested on Linux/Clang only.