Add some missing custom request #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
reviewed
Dec 17, 2025
voodoos
approved these changes
Dec 18, 2025
Collaborator
voodoos
left a comment
voodoos
left a comment
There was a problem hiding this comment.
Thanks, just need to sanitize the path in the test...
Collaborator
|
Thanks @xvw ! |
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Dec 20, 2025
CHANGES: ## Features - Make `code-lens` for nested let bindings configurable (ocaml/ocaml-lsp#1567) - Add support for `.mlx` files, including formatting via `ocamlformat-mlx` and most OCaml LSP features (diagnostics, code actions, hover, etc.) (ocaml/ocaml-lsp#1528) - Add `typeExpression` custom request (ocaml/ocaml-lsp#1576) - Add `locate` custom request (ocaml/ocaml-lsp#1576) - Add `phrase` custom request (ocaml/ocaml-lsp#1576) ## Fixes - Improve precision of collected metrics timestamps. (ocaml/ocaml-lsp#1565) - Fallback on `.merlin` configuration if no `dune-project` file is found and if `dot-merlin-reader` is installed. (ocaml/ocaml-lsp#1563, fixes ocaml/ocaml-lsp#1522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three custom request:
ocamllsp/typeExpressionocamllsp/phraseocamllsp/locate(fix [protocol] add an optional parameter for looking for a given identifier fordefiniton/declarationrequest #1570)Adding an optional parameter to definition/declaration/type-definition search queries posed problems because the parameter types are generated by the Cinaps preprocessor, hence the addition of a custom request (based on the LSP request code).