You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add autoload to caml-mode so it can be called without doing (require 'caml). Adjust auto-mode-alist so it can be load automatically when the extensions matches.
Looks good to me as well, although I'd probably split this into two commits. You might also adjust the README, as it currently suggests setting up the file extension mappings manually.
Hmm... I agree with the autoload cookie, of course )(and I just merged this part), but I'm not so sure about the auto-mode-alist change because I think it'll conflict with the one in Tuareg-mode.
AFAIK the "recommended" major mode is Tuareg-mode, but installing Tuareg also installs Caml-mode, so I'd rather not inflict this conflict on all the Tuareg users.
Maybe we could use major-mode-remap-alist to resolve the conflict, but that'll only be available in Emacs-30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add autoload to
caml-modeso it can be called without doing(require 'caml). Adjustauto-mode-alistso it can be load automatically when the extensions matches.