Refactor main docks toggle and integration and browser docks #7636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2022
tytan652
added
Enhancement
tytan652
force-pushed
the
refactor_docks
branch
from
b53de5a to
a346a4f
Compare
tytan652
force-pushed
the
refactor_docks
branch
from
a346a4f to
581531e
Compare
tytan652
force-pushed
the
refactor_docks
branch
from
581531e to
a833c64
Compare
tytan652
force-pushed
the
refactor_docks
branch
2 times, most recently
from
919c8de to
2e519de
Compare
WizardCM
reviewed
Jan 26, 2023
tytan652
force-pushed
the
refactor_docks
branch
from
2e519de to
d40337c
Compare
Collaborator
Author
|
Old docks are now added before the separator if it exist. Edit: I just forgot to add that. |
tytan652
force-pushed
the
refactor_docks
branch
from
d40337c to
e4c810d
Compare
tytan652
force-pushed
the
refactor_docks
branch
from
e4c810d to
39bb810
Compare
tytan652
force-pushed
the
refactor_docks
branch
3 times, most recently
from
6512380 to
c073797
Compare
tytan652
force-pushed
the
refactor_docks
branch
2 times, most recently
from
4e52466 to
9abfbda
Compare
tytan652
force-pushed
the
refactor_docks
branch
2 times, most recently
from
671cd52 to
5188ad3
Compare
Use the QAction provided by QDockWidget with new Qt connection rather than creating a new one for each dock.
Use the QAction provided by QDockWidget with new Qt connection rather than creating a new one for each dock. Separate extra browser docks from extra docks, the latter is meant for plugin/integration docks.
tytan652
force-pushed
the
refactor_docks
branch
from
5188ad3 to
6aa8125
Compare
WizardCM
approved these changes
Mar 17, 2023
Member
There was a problem hiding this comment.
Tested as heavily as I could, with a combination of
- custom browser docks, service integration via Twitch, YouTube and Restream
- docking, undocking
- switching scene collections & profiles
- linking & unlinking service integration
Nothing in the code stands out to me as unreadable or broken.
Looks good to merge to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependency of:
Groundwork for other PRs and also avoid creating QActions by using the one included in the dock by modifying its connections making it usable even while the docks are locked.
Motivation and Context
Preparation for PRs that depends on this one.
How Has This Been Tested?
Types of changes
Checklist: