Skip to content

Conversation

@kkartaltepe
Copy link
Collaborator

Description

Deletes some unused variables.

Motivation and Context

These break builds eventually, not sure why they don't right now.

How Has This Been Tested?

It builds.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable) -->

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX
Copy link
Member

RytoEX commented Apr 14, 2024

8bcf266#diff-12619fdf5b78428302136e0272174358004ba1bfdbf3ee60ccae48e4613e587d

Do you want to also catch this?

g_autoptr(GHashTable) framerates_map = NULL;

Unused variables and missing switch branches will break in cmake 3.0,
and are breaking for me right now so let's merge this early.
@kkartaltepe
Copy link
Collaborator Author

Thanks added all the pipewire changes from Pat's fixup so he can just drop the pipewire files.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already reviewed these on #9787, so these look fine to me. Going to let CI confirm.

@RytoEX RytoEX self-assigned this Apr 14, 2024
@RytoEX RytoEX added the Code Cleanup Non-breaking change which makes code smaller or more readable label Apr 14, 2024
@RytoEX RytoEX merged commit befce71 into obsproject:master Apr 14, 2024
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Cleanup Non-breaking change which makes code smaller or more readable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants