Open
Conversation
sigrunixia
requested changes
Jul 30, 2025
sigrunixia
left a comment
There was a problem hiding this comment.
Please fix these minor issues and I will merge.
| Headings with links | ||
| # [[Markdown|Heading 1 – note exists]] | ||
| # [[NoSuchFile|Heading 1 – note doesn't exist]] | ||
| # [[https://obsidian.md|Heading 1 – external]] |
There was a problem hiding this comment.
This is formatted incorrectly. Please format as an external link.
| # [[https://obsidian.md|Heading 1 – external]] | ||
| ## [[Markdown|Heading 2 – note exists]] | ||
| ## [[NoSuchFile|Heading 2 – note doesn't exist]] | ||
| ## [[https://obsidian.md|Heading 2 – external]] |
There was a problem hiding this comment.
This is formatted incorrectly. Please format as an external link.
| ## [[https://obsidian.md|Heading 2 – external]] | ||
| ### [[Markdown|Heading 3 – note exists]] | ||
| ### [[NoSuchFile|Heading 3 – note doesn't exist]] | ||
| ### [[https://obsidian.md|Heading 3 – external]] |
There was a problem hiding this comment.
This is formatted incorrectly. Please format as an external link.
| ### [[https://obsidian.md|Heading 3 – external]] | ||
| #### [[Markdown|Heading 4 – note exists]] | ||
| #### [[NoSuchFile|Heading 4 – note doesn't exist]] | ||
| #### [[https://obsidian.md|Heading 4 – external]] |
There was a problem hiding this comment.
This is formatted incorrectly. Please format as an external link.
| #### [[https://obsidian.md|Heading 4 – external]] | ||
| ##### [[Markdown|Heading 5 – note exists]] | ||
| ##### [[NoSuchFile|Heading 5 – note doesn't exist]] | ||
| ##### [[https://obsidian.md|Heading 5 – external]] |
There was a problem hiding this comment.
This is formatted incorrectly. Please format as an external link.
| ##### [[https://obsidian.md|Heading 5 – external]] | ||
| ###### [[Markdown|Heading 6 – note exists]] | ||
| ###### [[NoSuchFile|Heading 6 – note doesn't exist]] | ||
| ###### [[https://obsidian.md|Heading 6 – external]] |
There was a problem hiding this comment.
This is formatted incorrectly. Please format as an external link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of adjustments to the Headings note.
First, I've removed empty lines. This makes it easier to see the inherent spacing that the theme developer is applying as CSS.
Second, I've added a section for headings that are links. As these will typically be a different colour, it's useful to see how they look against the note background, and especially whether they have enough contrast for readability.