Skip to content

Conversation

@jnation3406
Copy link
Member

@jnation3406 jnation3406 commented Aug 10, 2022

Here's the full set of changes from the interns. This branch has already pulled in the feature/optimize_airmass branch, which is why I have it diff-ing off that branch rather than main. When reviewing, focus on the simulate package and specifically the metrics/plots files.


# assumption: if it's trying to read the licence, it's probably linked properly
strace -e openat python -c "from ortools.linear_solver import pywraplp as p; p.Solver.CreateSolver('GUROBI')" 2>&1 | grep -q gurobi.lic
# strace -e openat python -c "from ortools.linear_solver import pywraplp as p; p.Solver.CreateSolver('GUROBI')" 2>&1 | grep -q gurobi.lic
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just so the interns could build the container without full priviledges - we can remove this comment


def __init__(self, configdb_url, telescope_classes, telescopes_file='data/telescopes.json',
active_instruments_file='data/active_instruments.json'):
active_instruments_file='data/active_instruments.json', overrides=None):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file all pertain to being able to override configdb values with a dict provided (which can be read in from a simple json file in the simulation orchestrator)

@jnation3406 jnation3406 self-assigned this Aug 11, 2022
Base automatically changed from feature/optimize_airmass to main August 15, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants