Skip to content

Feature/test coverage #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vlkolak wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/test coverage #11

vlkolak wants to merge 3 commits into from

Conversation

@vlkolak
Copy link

@vlkolak vlkolak commented Oct 20, 2017

Changes:

  • bootstraped Codeception
  • fixed namespace bug on Link (luckily it was used only in its local namespace, therefore no breakings changes)
  • unit test for Link
  • MySqlGatewayTestTrait for common tests functions
  • IdentifiableMySqli to ease assertions (and to work around a cloning issue for \mysqli mocks coming from dataProviders
  • AbstractMySqlGateway tests for : getLinks, registerLink, purge, fetch, fetchAll
  • AbstractMySqlGateway getLinks bugfix as in Fix strange issue where low-method links could be used for higher-level method calls #10

@vlkolak
Changes:
6fccd33 
- bootstraped Codeception
- fixed namespace bug on Link (luckily it was used only in its local namespace, therefore no breakings changes)
- unit test for Link
@vlkolak
Changes:
2f69250 
 - MySqlGatewayTestTrait for common tests functions
 - IdentifiableMySqli to ease assertions (and to work around a cloning issue for \mysqli mocks coming from dataProviders
 - AbstractMySqlGateway getLinks && registerLink tests
 - AbstractMySqlGateway getLinks bugfix as in objective-php#10
@vlkolak
a few more unit tests
47f9316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vlkolak