Skip to content

python: support aarch64 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rnpnr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python: support aarch64 #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/python/gen.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ cflags{
'-isystem $builddir/pkg/linux-headers/include',
}

if config.target.platform:match('[^-]*') == 'x86_64' then
cflags{
'-D HAVE_GCC_ASM_FOR_X64=1',
'-D HAVE_GCC_ASM_FOR_X87=1',
}
end

pkg.deps = {'pkg/linux-headers/headers'}
local libs = {}
local modules = load 'modules.lua'
Expand Down
4 changes: 2 additions & 2 deletions pkg/python/pyconfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@
#define HAVE_GAI_STRERROR 1
/* #undef HAVE_GAMMA */
/* #undef HAVE_GCC_ASM_FOR_MC68881 */
#define HAVE_GCC_ASM_FOR_X64 1
#define HAVE_GCC_ASM_FOR_X87 1
/* #undef HAVE_GCC_ASM_FOR_X64 */
/* #undef HAVE_GCC_ASM_FOR_X87 */
Copy link
Collaborator

@michaelforney michaelforney Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could just guard this by

#if __x86_64__
...
#endif

Copy link
Contributor Author

@rnpnr rnpnr Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you could. One reason to keep it as I’ve written it is that if you update the header on an amd64 system and forget to include the #if __x86_64__ the compiler will warn you about redefining those macros

I could go either way though.

#define HAVE_GCC_UINT128_T 1
#define HAVE_GETADDRINFO 1
#define HAVE_GETC_UNLOCKED 1
Expand Down