-
Notifications
You must be signed in to change notification settings - Fork 165
Add motifcheck actor for RHEL 9 to RHEL 10 upgrade #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add a new actor to detect the Motif package on RHEL 9 systems and warn users that Motif is no longer available in RHEL 10. The actor creates a high-severity report recommending migration to alternative GUI toolkits such as GTK or Qt. Related: DESKTOP-1399
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the leapp-repository contribution and development guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
|
/packit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes required, other than that looks good. Also please make the linter happy, you can see what it complains about in the GitHub action.
repos/system_upgrade/el9toel10/actors/motifcheck/libraries/motifcheck.py
Outdated
Show resolved
Hide resolved
repos/system_upgrade/el9toel10/actors/motifcheck/libraries/motifcheck.py
Outdated
Show resolved
Hide resolved
repos/system_upgrade/el9toel10/actors/motifcheck/libraries/motifcheck.py
Show resolved
Hide resolved
repos/system_upgrade/el9toel10/actors/motifcheck/tests/test_motifcheck.py
Outdated
Show resolved
Hide resolved
|
/packit test |
…ifcheck.py Co-authored-by: Matej Matuška <matko.matuska@gmail.com>
…tifcheck.py Co-authored-by: Matej Matuška <matko.matuska@gmail.com>
Add a new actor to detect the Motif package on RHEL 9 systems and warn users that Motif is no longer available in RHEL 10. The actor creates a high-severity report recommending migration to alternative GUI toolkits such as GTK or Qt.
Related: DESKTOP-1399
This is my first PR for this project so please excuse potential issues, let me please know how should I fix them.