update position before firing onChange #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems impossible to get the updated fen string on trash/drop without this. (I'm printing the fen string out on any user activity).
Enables widget.fen() to pass the current fen string when the onChange event is called. objToFen(oldPos/newPos) still return expected values.
I think this was the issue all along. <code>Chessboard.objToFen(oldPos)</code> was returning the newPos and vice versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use shorthand
widget.fen()and get the FEN string that matchesChessboard.objToFen(newPos)within theonChangeevent. Without it callingwidget.fen()within theonChange()event returns the value that matchesChessboard.objToFen(oldPos).